A compromised or malicious owner of StableToken can mint any amount of the stable coins.

[code423n4]

Lines of code

https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/StableToken.sol#L38

Vulnerability details

Impact

Detailed description of the impact of this finding.
A compromised or malicious owner of StableToken can mint any amount of the stable coins.

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.
.
A compromised or malicious owner of StableToken can mint any amount of the stable coins as follows:

1. Call function setMinter(badMinter, true) so that badMinter becomes a legal minter;
2. badMinter calls mintFor(attackerA, amount) to get amount of stable coins
3. attackerA then use the amount of stable coins to trade and get back other stable coins that are safe and popular in the market.
4. repeat the above until the whole system is drained of other liquidity.

Tools Used

Remix

Recommended Mitigation Steps

Set the minters in the constructor only during deployment. If new minters are needed, then use a proxy pattern to upgrade.

[c4-judge]

GalloDaSballo marked the issue as duplicate of #383

[c4-judge]

GalloDaSballo marked the issue as duplicate of #377

[c4-judge]

GalloDaSballo marked the issue as satisfactory