Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #658

Open
code423n4 opened this issue Dec 16, 2022 · 6 comments
Open

QA Report #658

code423n4 opened this issue Dec 16, 2022 · 6 comments
Labels
bug Something isn't working grade-b Q-11 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Dec 16, 2022
code423n4 added a commit that referenced this issue Dec 16, 2022
@code423n4
rbserver issue #658
b28cb30
code423n4 added a commit that referenced this issue Dec 16, 2022
@code423n4
rbserver data for issue #658
a1bd4a1
@GalloDaSballo
Copy link

GalloDaSballo commented Dec 27, 2022 •
edited

[L-01] NO UPPER LIMIT ON NUMBER OF REWARD ASSET TOKENS IN GovNFT CONTRACT

L

[L-02] super._safeMint FUNCTION CAN BE CALLED INSTEAD OF super._mint FUNCTION FOR MINTING GOVERNANCE NFTS

L

[L-03] super._safeTransfer FUNCTION CAN BE CALLED INSTEAD OF super._transfer FUNCTION FOR TRANSFERRING GOVERNANCE NFTS

L

[L-04] USDT IS NOT SUPPORTED FOR CALLING Trading._handleDeposit FUNCTION ON ETHEREUM MAINNET

Dup 198 / M-12

[L-05] MARGIN ASSET TOKENS WITH MORE THAN 18 DECIMALS ARE NOT SUPPORTED

Dup 533 / M-01

[L-06] UNSAFE decimals() CALL FOR MARGIN ASSET TOKENS THAT DO NOT IMPLEMENT decimals()

L

@c4-sponsor c4-sponsor added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 5, 2023
@c4-sponsor
Copy link

GainsGoblin marked the issue as sponsor confirmed

C4-Staff added a commit that referenced this issue Jan 6, 2023
@C4-Staff
original risk added for issue #658
a04b9ec
@c4-judge c4-judge mentioned this issue Jan 16, 2023
Closed
@GalloDaSballo
Copy link

4L

This was referenced Jan 22, 2023
Closed
Closed
c4-judge added a commit that referenced this issue Jan 22, 2023
@c4-judge
Upgraded Q -> M from #658 [1674423084300]
9a1fb60
@c4-judge c4-judge mentioned this issue Jan 22, 2023
Closed
c4-judge added a commit that referenced this issue Jan 22, 2023
@c4-judge
Upgraded Q -> M from #658 [1674423108320]
b0d43cb
@GalloDaSballo
Copy link

2L from dups

6L

@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as grade-b

@GalloDaSballo
Copy link

Despite the report "mathematically not making it", I chose to award it a B because it in aggregate is very valuable (6 Low Severity findings)

@C4-Staff C4-Staff added the Q-11 label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-b Q-11 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GalloDaSballo @code423n4 @c4-judge @c4-sponsor @C4-Staff