Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #662

Open
code423n4 opened this issue Dec 16, 2022 · 4 comments
Open

QA Report #662

code423n4 opened this issue Dec 16, 2022 · 4 comments
Labels
bug Something isn't working grade-b Q-12 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Dec 16, 2022
code423n4 added a commit that referenced this issue Dec 16, 2022
@code423n4
Deivitto issue #662
d1ef006
code423n4 added a commit that referenced this issue Dec 16, 2022
@code423n4
Deivitto data for issue #662
3ab50a0
@GalloDaSballo
Copy link

GalloDaSballo commented Dec 27, 2022 •
edited

Missing event emission and lack of parameters validations in setters

1R 1NC

Deprecated Library

R

Emitted amount can be bigger than expected

Unclear, skipping (also unprofessional notes)

_safeMint() should be used rather than _mint() wherever possible

L

Single-step process for critical ownership transfer/renounce is risky

NC

Missing checks for address(0x0) when assigning values to address state or immutable variables

L

2L 2R 2NC

@c4-sponsor
Copy link

GainsGoblin marked the issue as sponsor confirmed

@c4-sponsor c4-sponsor added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 5, 2023
C4-Staff added a commit that referenced this issue Jan 6, 2023
@C4-Staff
original risk added for issue #662
16e944a
This was referenced Jan 15, 2023
Closed
Closed
Closed
@GalloDaSballo
Copy link

3L from dups

5L 2R 2Nc

@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as grade-b

@C4-Staff C4-Staff added the Q-12 label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-b Q-12 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GalloDaSballo @code423n4 @c4-judge @c4-sponsor @C4-Staff