Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #663

Open
code423n4 opened this issue Dec 16, 2022 · 5 comments
Open

Gas Optimizations #663

code423n4 opened this issue Dec 16, 2022 · 5 comments
Labels
bug Something isn't working G (Gas Optimization) G-07 grade-b sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 16, 2022
code423n4 added a commit that referenced this issue Dec 16, 2022
@code423n4
Deekshith99 issue #663
4b6534d
code423n4 added a commit that referenced this issue Dec 16, 2022
@code423n4
Deekshith99 data for issue #663
f057c25
@GalloDaSballo
Copy link

[G-1] State variables and struct can be closely packed to save gas

### 1st instance in the Trading.sol in the Fees struct
All are read at same time, so it will save reading 2 slots

4.2k

2nd

Unclear, skipping

3rd

2.1k

4th

2.1k

8400

C4-Staff added a commit that referenced this issue Jan 6, 2023
@C4-Staff
original risk added for issue #663
b69f84a
@c4-sponsor
Copy link

GainsGoblin marked the issue as sponsor confirmed

@c4-sponsor c4-sponsor added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 9, 2023
@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as grade-b

@GalloDaSballo
Copy link

Simple report, high impact, barely made it, good start!

@GalloDaSballo
Copy link

In contrast to other reports, I chose to award a B to this one despite it "mathematically falling short" because of the conciseness and value of each individual reports.

Going forward I recommend more wardens focus on High Impact Findings which will ultimately produce better reports for everyone

@C4-Staff C4-Staff added the G-07 label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) G-07 grade-b sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GalloDaSballo @code423n4 @c4-judge @c4-sponsor @C4-Staff