Cryptor data for issue #206

code-423n4 · Jan 13, 2023 · baa9973 · baa9973
1 parent 14f74b9
commit baa9973
Showing 1 changed file with 32 additions and 0 deletions.
diff --git a/data/Cryptor-Q.md b/data/Cryptor-Q.md
@@ -0,0 +1,32 @@
+# ClearingHouse.sol SafeBatchTransferFrom is useless and empty 
+The following function is empty and should be removed 
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/ClearingHouse.sol#L180-L186
+
+# VaultImplementation.sol Modifier suggested 
+The following require statement is used multiple times in the contract and can be substituted for a modifier for better code readability
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/VaultImplementation.sol#L96
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/VaultImplementation.sol#L78
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/VaultImplementation.sol#L105
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/VaultImplementation.sol#L114
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/VaultImplementation.sol#L147
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/VaultImplementation.sol#L211
+
+
+# VaultImplementation empty Functions 
+
+The following functions are empty 
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/VaultImplementation.sol#L268-L277
+
+
+# Withdraw Proxy function can just be variable instead 
+The following function can simply just be a variable inside of another function 
+
+https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/WithdrawProxy.sol#L77