Incorrect operator in CollateralToken.settleAuction checks

[code423n4]

Lines of code

https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/CollateralToken.sol#L526

Vulnerability details

Description:

CollateralToken.settleAuction intends to enforce that both an auction exists for the collateralId and the ClearingHouse is the owner of the collateral, but instead it enforces only one of them by only reverting if they're both invalid.

Remediation:

if (
  s.collateralIdToAuction[collateralId] == bytes32(0) &&
  ERC721(s.idToUnderlying[collateralId].tokenContract).ownerOf(
    s.idToUnderlying[collateralId].tokenId
  ) !=
  s.clearingHouse[collateralId]
) {
  revert InvalidCollateralState(InvalidCollateralStates.NO_AUCTION);
}

Should be replaced with

if (
  s.collateralIdToAuction[collateralId] == bytes32(0) ||
  ERC721(s.idToUnderlying[collateralId].tokenContract).ownerOf(
    s.idToUnderlying[collateralId].tokenId
  ) !=
  s.clearingHouse[collateralId]
) {
  revert InvalidCollateralState(InvalidCollateralStates.NO_AUCTION);
}

[c4-judge]

Picodes marked the issue as duplicate of #582

[c4-judge]

Picodes marked the issue as satisfactory