minDepositAmount is compared against a wrong variable

[code423n4]

Lines of code

https://github.com/AstariaXYZ/astaria-gpl/blob/4b49fe993d9b807fe68b3421ee7f2fe91267c9ef/src/ERC4626-Cloned.sol#L27
https://github.com/AstariaXYZ/astaria-gpl/blob/4b49fe993d9b807fe68b3421ee7f2fe91267c9ef/src/ERC4626-Cloned.sol#L43

Vulnerability details

The following require statement In deposit of ERC4626-Cloned.sol

require(shares > minDepositAmount(), "VALUE_TOO_SMALL");

is ensuring shares is greater than minDepositAmount(), even though it should be ensuring assets > minDepositAmount() (like how it’s done in the mint method).

Impact

An unexpected amount of assets can be deposited; or a valid amount of assets cannot be deposited.

Proof of Concept

See the attached links.

Tools Used

Manual analysis

Recommended Mitigation Steps

Fix the require statement with the right invariant.

[c4-judge]

Picodes marked the issue as duplicate of #486

[c4-judge]

Picodes marked the issue as satisfactory