Improper design results in large minimum deposit requirement for high-value tokens, preventing most investors

[code423n4]

Lines of code

https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/PublicVault.sol#L96-L108

Vulnerability details

Impact

If the asset is WBTC, under the current design, the minDepositAmount will be 0.1 WBTC, valued more than 2000 US dollars, which is a excessively high minimum single investment amount for most investors, seriously affecting the efficiency of fundraising investment.

Proof of Concept

https://github.com/code-423n4/2023-01-astaria/blob/1bfc58b42109b839528ab1c21dc9803d663df898/src/PublicVault.sol#L96-L108

function minDepositAmount()
    public
    view
    virtual
    override(ERC4626Cloned)
    returns (uint256)
  {
    if (ERC20(asset()).decimals() == uint8(18)) {
      return 100 gwei;
    } else {
      return 10**(ERC20(asset()).decimals() - 1);
    }
  }

WBTC decimals is 8, minDepositAmount() for WBTC will be 10**7 wei worth more than 2000 USD

Recommended Mitigation Steps

consider add a storage minDepositAmount in VIData, and let owner set it

[c4-judge]

Picodes marked the issue as duplicate of #367

[c4-judge]

Picodes marked the issue as satisfactory