Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #61

Open
code423n4 opened this issue Jan 29, 2023 · 3 comments
Open

QA Report #61

code423n4 opened this issue Jan 29, 2023 · 3 comments
Labels
bug Something isn't working edited-by-warden grade-b Q-13 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jan 29, 2023
code423n4 added a commit that referenced this issue Jan 29, 2023
code423n4 added a commit that referenced this issue Jan 29, 2023
code423n4 added a commit that referenced this issue Jan 30, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Jan 31, 2023
code423n4 added a commit that referenced this issue Feb 2, 2023
code423n4 added a commit that referenced this issue Feb 3, 2023
@GalloDaSballo
Copy link

QA1
R, I think it's fine in this case, but worth flagging

QA2
L

QA3
NC

QA4
R

QA5
NC

QA6
Disputing, they use immutable for the logic and the proxy doesn't initialize, it's fine, but if you think it has issues, do send a follow up report (coded POC pls)

QA7
R

QA8
NC

QA9
NC

QA10
R

QA11
R

QA12
Invalid, ECDSA recover will check for address(0)

@GalloDaSballo
Copy link

1L 5R 3Nc

@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as grade-b

@C4-Staff C4-Staff added the Q-13 label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working edited-by-warden grade-b Q-13 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

4 participants