Skip to content

Commit

Permalink
SovaSlava data for issue #360
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Jan 29, 2023
1 parent 99a6908 commit 19649f5
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions data/SovaSlava-Q.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Modifier onlyAdminWithdrawAfterEnd() in Quest.sol dont have check of msg.sender. Advice to rename onlyAdminWithdrawAfterEnd to withdrawAfterEnd
```
modifier onlyAdminWithdrawAfterEnd() {
if (block.timestamp < endTime) revert NoWithdrawDuringClaim();
_;
// NO CHECKS MSG.SENDER == OWNER
}
```
its not critical, because receiver of fee is set in constructor

0 comments on commit 19649f5

Please sign in to comment.