Skip to content

Commit

Permalink
Report for issue #263 updated by xAriextz
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Jan 29, 2023
1 parent 4da55f1 commit 612e329
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions data/xAriextz-Q.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ I suggest to use the functions the library of AccessControl provides directly, i
Link: https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f71221570b14a0479c216583342bd652d8d/contracts/QuestFactory.sol#L227-L228
I suggest to emit the event after the mint function is called.

## Every contract

This is something that happens in every contract:
From the article Security Pitfalls And Best practices 101 from Secureum: Unlocked pragma: Contracts should be deployed using the same compiler version/flags with which they have been tested. Locking the pragma (for e.g. by not using ^ in pragma solidity 0.5.10) ensures that contracts do not accidentally get deployed using an older compiler version with unfixed bugs.



Expand Down

0 comments on commit 612e329

Please sign in to comment.