DOS due to Block.gas limit if the Claimers have many tokens to claim

[code423n4]

Lines of code

https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f71221570b14a0479c216583342bd652d8d/contracts/Quest.sol#L96-L118
https://github.com/rabbitholegg/quest-protocol/blob/8c4c1f71221570b14a0479c216583342bd652d8d/contracts/RabbitHoleReceipt.sol#L106-L135

Vulnerability details

Impact

 If they are many tokens to be claimed by the claim() function this will actually exceed the block.gaslimit and the claimer cannot claim any token. 
 This  is  because the claim function calls the getOwnedTokenIdsOfQuest() function which has two loops going on it, the claim() function checks in a 
 loop whether the tokens are claimed and also it calls the _setClaimed() function which consists of a loop.

Proof of Concept

  Suppose they are 50 tokens to be claimed by the claimer now the function will surely revert due to block.gaslimit and as mentioned above why will 
  it happens.

Tools Used

 Pen and Paper

Recommended Mitigation Steps

 It is always recommended to have a maximum claiming of rewards per transaction instead of claiming all the tokens at a time. For example, it is 
 better to claim rewards for 10 tokens at a time if the claimer has 50 tokens so that the person can call the function 5 times and claim all the tokens.

[c4-judge]

kirk-baird marked the issue as duplicate of #135

[c4-judge]

kirk-baird changed the severity to 2 (Med Risk)

[c4-judge]

kirk-baird marked the issue as satisfactory