Skip to content

Commit

Permalink
Report for issue #40 updated by SaeedAlipoor01988
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Feb 26, 2023
1 parent 1e23443 commit a9b096e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion data/SaeedAlipoor01988-G.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ manually
Sample report approved by C4 judges team.
https://code4rena.com/reports/2022-11-non-fungible/#g-09-require-or-revert-statements-that-check-input-arguments-should-be-at-the-top-of-the-function

######### unnecessary check for _requireTroveIsActive #########
######### Unnecessary duplicate check #########

#### Impact
_requireTroveIsActive is a function in TroveManager to check that Troves[_borrower][_collateral].status is active or not. in contract BorrowerOperations and functions _adjustTrove, before making calls to applyPendingRewards, we make the call to function BorrowerOperations._requireTroveisActive to check Trove is Active, then in contract TroveManager and function applyPendingRewards, again we check that Trove is Active by TroveManager._requireTroveIsActive function.
Expand Down

0 comments on commit a9b096e

Please sign in to comment.