Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigation Confirmed for Mitigation of M-02 Issue mitigated #27

Open
code423n4 opened this issue Feb 14, 2023 · 1 comment
Open

Mitigation Confirmed for Mitigation of M-02 Issue mitigated #27

code423n4 opened this issue Feb 14, 2023 · 1 comment
Labels
mitigation-confirmed MR-M-02 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

C4 issue

M-02: Coding logic of the contract upgrading renders upgrading contracts impractical

Comments

The original implementation was deleting the addresses associated with the contract name just after setting it.
Due to that, it was practically difficult to upgrade the contracts.

Mitigation

PR #32
The mitigation resolved the issue and I confirm the original issue does not exist anymore.

Test

There are new tests added to confirm the upgradability with the same names and all are passing.

Conclusion

LGTM
code423n4 added a commit that referenced this issue Feb 14, 2023
@code423n4
hansfriese issue #27
a0ab8bc
@c4-judge
Copy link

GalloDaSballo marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mitigation-confirmed MR-M-02 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Simon-Busch @code423n4 @c4-judge