Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigation Confirmed for M-22 #64

Open
code423n4 opened this issue Feb 17, 2023 · 1 comment
Open

Mitigation Confirmed for M-22 #64

code423n4 opened this issue Feb 17, 2023 · 1 comment
Labels
mitigation-confirmed MR-M-22 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

Issue mitigated

Original issue: M-22: RecollateralizationLib: Dust loss for an asset should be capped at its low value

Explanation

  • Issue was that minTradeVolume was subtracted from each asset, even if the balance is less than that
  • Under the mitigation, the subtraction of minTradeVolume is done individually for each asset, and if the asset has a balance that’s worth less than minTradeVolume its value is reduced to zero. Therefore issue mitigated.
code423n4 added a commit that referenced this issue Feb 17, 2023
@code423n4
0xA5DF issue #64
2665683
@c4-judge
Copy link

0xean marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mitigation-confirmed MR-M-22 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @c4-judge