Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigation Confirmed for GAS #24

Open
code423n4 opened this issue Mar 20, 2023 · 1 comment
Open

Mitigation Confirmed for GAS #24

code423n4 opened this issue Mar 20, 2023 · 1 comment
Labels
mitigation-confirmed MR-Gas satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

Gas Report Mitigation Review - Partially Alleviated

KBC-01G: Alleviated

The data location of the variable has been appropriately adjusted to calldata, optimizing its read-access gas cost.

KBC-02G: Alleviated

The variable declaration has been adjusted as advised.

KIB-01G: Alleviated

The redundant contract-level variable has been safely omitted from the codebase.

KIB-02G: Alleviated

All four instances of redundant self-calls have been safely replaced by internal calls.

KIB-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KAP-01G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-01G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-02G: Partially Alleviated

All but the first instance have been properly optimized, rendering this exhibit partially alleviated.

KFC-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-04G: Alleviated

A local variable is now updated on each iteration with only a single storage update occurring after the for loop, optimizing the code as advised.

KFC-05G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-06G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KSP-01G: Alleviated

The explicit function names have been removed as advised, optimizing the function's memory allocation.

KSP-02G: Alleviated

The loop limit evaluation is now cached to a local variable as advised, optimizing each iteration's gas cost.

KSP-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KYC-01G: Alleviated

The redundant overrides of individual functions were removed, instead overriding the _beforeTokenTransfer function optimally.

KBT-01G: Alleviated

The redundant overrides of individual functions were removed, instead overriding the _beforeTokenTransfer function optimally.

KBT-02G: Alleviated

The msg.sender statement is now in use throughout the contract, alleviating the inconsistency outlined by the exhibit.

MRF-01G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

MRF-02G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

MRF-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

MAR-01G: Alleviated

The startedAt variable is now properly assigned to the _updatedAt value, ensuring that the function conforms closer to the Chainlink standard and does not yield empty variables.

@c4-judge
Copy link

GalloDaSballo marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-Gas satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants