Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M-02 Unmitigated #15

Open
code423n4 opened this issue Jun 21, 2023 · 2 comments
Open

M-02 Unmitigated #15

code423n4 opened this issue Jun 21, 2023 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working confirmed for report This issue is confirmed for report MR-M-02 satisfactory satisfies C4 submission criteria; eligible for awards unmitigated

Comments

@code423n4
Copy link
Contributor

Lines of code

Vulnerability details

Mitigation of M-02: Issue partially mitigated, see comments

Link to Issue: code-423n4/2023-05-ambire-findings#18

Comments

While the issue mentioned in M-02 has been technically mitigated, the same attack can be performed in another function present in the wallet.

The report describes an attack in which a malicious relayer can force the failure of calls to tryCatch. The issue in this specific function has been mitigated, however the same attack can be performed in the function tryCatchLimit. This new issue is expanded in [adriro-NEW-M-01].

Assessed type

Other
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working MR-M-02 unmitigated labels Jun 21, 2023
code423n4 added a commit that referenced this issue Jun 21, 2023
@code423n4
adriro issue #15
63a275d
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Jun 23, 2023
@c4-judge
Copy link

Picodes marked the issue as satisfactory

@c4-judge
Copy link

Picodes marked the issue as confirmed for report

@c4-judge c4-judge added the confirmed for report This issue is confirmed for report label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working confirmed for report This issue is confirmed for report MR-M-02 satisfactory satisfies C4 submission criteria; eligible for awards unmitigated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @c4-judge