Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #4

Open
code423n4 opened this issue Jul 5, 2023 · 3 comments
Open

QA Report #4

code423n4 opened this issue Jul 5, 2023 · 3 comments
Labels
bug Something isn't working grade-a Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 5, 2023
code423n4 added a commit that referenced this issue Jul 5, 2023
@code423n4
Lambda issue #4
599271e
code423n4 added a commit that referenced this issue Jul 5, 2023
@code423n4
Lambda data for issue #4
024e3e2
@c4-judge
Copy link

hansfriese marked the issue as grade-a

@c4-judge c4-judge added grade-a selected for report This submission will be included/highlighted in the audit report labels Jul 10, 2023
@c4-judge
Copy link

hansfriese marked the issue as selected for report

@hansfriese
Copy link

Low

  • DiamondProxy License
  • Nested Loop in Redeemer._redeem
  • (Temporary) manipulations of IManager.totalAssets() would break the system
  • Third Order Taylor Approximation can be imprecise
  • Grifting possibilities for strategies
  • Collateral may not be revokable because of rounding
  • Swapper assumes 18 decimals for the stable coin

NC

  • RewardHandler.sellRewards requires trust in seller
  • Reliance on decimals()
  • System may use prices that never existed

@C4-Staff C4-Staff added the Q-04 label Jul 13, 2023
@code423n4 code423n4 mentioned this issue Jul 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-a Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hansfriese @code423n4 @c4-judge @C4-Staff