QA MitigationConfirmed

[code423n4]

Lines of code

Vulnerability details

The sponsor addressed various QA / low severity findings and performed a few other minor changes:

• Sanity checks for the array length were added
• Functions were converted to pure when possible
• Named imports are now used in many places
• Events were indexed
• A few wrong comments were changed
• The guardian is now allowed to reduce the rate in the Savings contract
• Savings.setSurplusManager now emits an event
• The license of DiamondProxy was changed
• oracleQuoteType and OracleTargetType were removed, there is now only OracleReadType. This data structure change also resulted in a few code changes
• The implementation address is now exposed to Etherscan for a better UX there
• The unnecessary Chainlink roundId > answeredInRound check was removed
• LibWhitelist now also supports querying external contracts

These changes introduced no new vulnerabilities.

[c4-judge]

hansfriese marked the issue as satisfactory