Gas MitigationConfirmed

[code423n4]

Lines of code

Vulnerability details

Original Issue

• Gas Optimizations 2023-06-angle-findings#47
• Gas Optimizations 2023-06-angle-findings#35

Details

There are 2 GAS reports in total and some parts of them were mitigated.

Mitigation

PR1: AngleProtocol/merkl-contracts@3c2fe3a
PR2: AngleProtocol/angle-transmuter@66bba3f

• Unused variables issue
  Mitigated by omitting the unused variable.

• calldata instead of storage
  Partially mitigated.

• Redundant check
  Unmitigated.

• Validation check can be moved to setter
  Unmitigated.

• Use default initialization
  Mitigated by not setting default value.

• Use unchecked
  Unmitigated.

• Solidity 0.8.19 or later
  Unmitigated.

• x = x + y instead of x += y
  Partially mitigated.

• Not getting array length every time
  Mitigated.

• Use combined mappings
  Unmitigated.

• Resizing array instead of copying
  Mitigated.

Conclusion

I couldn't find a new issue during the GAS mitigation and I think the mitigation was done properly.

[c4-judge]

hansfriese marked the issue as satisfactory

[c4-judge]

hansfriese marked the issue as confirmed for report