Skip to content

Issues: code-423n4/2023-07-basin-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

135 Open 163 Closed
135 Open 163 Closed
Author
Filter by author
Label
Filter by label
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Milestones
Filter by milestone
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

ARRAY LENGTH MISMATCH CAN LEAD TO TRANSACTION REVERTS bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-b low quality report This report is of especially low quality primary issue Highest quality submission among a set of duplicates Q-01 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#294 opened Jul 10, 2023 by code423n4
5
_addLiquidity() can fail on zero amount transfers if treasury fee is set to zero bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-225 grade-a low quality report This report is of especially low quality Q-02 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax satisfactory satisfies C4 submission criteria; eligible for awards
#289 opened Jul 10, 2023 by code423n4
7
Constant Product formula overflowing if number of tokens in reserve is too high bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a low quality report This report is of especially low quality primary issue Highest quality submission among a set of duplicates QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#286 opened Jul 10, 2023 by code423n4
9
QA Report bug Something isn't working grade-b high quality report This report is of especially high quality Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#280 opened Jul 10, 2023 by code423n4
3
Tokens with multiple addresses should be blocklisted to prevent the creation of multiple pools for the same token bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#279 opened Jul 10, 2023 by code423n4
9
Gas Optimizations bug Something isn't working G (Gas Optimization) G-01 grade-a high quality report This report is of especially high quality sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#273 opened Jul 10, 2023 by code423n4
5
Gas Optimizations bug Something isn't working G (Gas Optimization) G-02 grade-a high quality report This report is of especially high quality selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#272 opened Jul 10, 2023 by code423n4
6
QA Report bug Something isn't working grade-b low quality report This report is of especially low quality Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#269 opened Jul 10, 2023 by code423n4
4
Unprotected Initializer bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a low quality report This report is of especially low quality Q-05 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#267 opened Jul 10, 2023 by code423n4
6
Gas Optimizations bug Something isn't working G (Gas Optimization) G-03 grade-b high quality report This report is of especially high quality sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#266 opened Jul 10, 2023 by code423n4
3
Recommended use of shift() is vulnerable to theft of all user's funds bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) downgraded by judge Judge downgraded the risk level of this issue grade-a primary issue Highest quality submission among a set of duplicates Q-06 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#264 opened Jul 10, 2023 by code423n4
16
Memory corruption in getBytes32FromBytes() can likely lead to loss of funds 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) downgraded by judge Judge downgraded the risk level of this issue judge review requested Judge should review this issue M-01 primary issue Highest quality submission among a set of duplicates satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#263 opened Jul 10, 2023 by code423n4
10
Gas Optimizations bug Something isn't working G (Gas Optimization) G-04 grade-a low quality report This report is of especially low quality
#262 opened Jul 10, 2023 by code423n4
2
QA Report bug Something isn't working grade-a high quality report This report is of especially high quality Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#261 opened Jul 10, 2023 by code423n4
7
Due to slot confusion, reserve amounts in the pump will be corrupted, resulting in wrong oracle values 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) downgraded by judge Judge downgraded the risk level of this issue M-02 primary issue Highest quality submission among a set of duplicates satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#260 opened Jul 10, 2023 by code423n4
8
Due to bit-shifting errors, reserve amounts in the pump will be corrupted, resulting in wrong oracle values 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) downgraded by judge Judge downgraded the risk level of this issue M-03 primary issue Highest quality submission among a set of duplicates satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#259 opened Jul 10, 2023 by code423n4
11
Incorrect storage parsing corrupts the reserves array read using LibBytes16 bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a primary issue Highest quality submission among a set of duplicates QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
#258 opened Jul 10, 2023 by code423n4
10
Inconsistent use of state variable uint256 constant ‘ONE-WORD’ across interacting contracts that use shared logic could result in incorrect calculations, incorrect assumptions about memory layout, and unexpected behaviors. bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a low quality report This report is of especially low quality Q-08 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#257 opened Jul 10, 2023 by code423n4
5
Lack of validation in ConstantProduct2 makes calcReserve output an invalid reserve amount, when index >1 bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) downgraded by judge Judge downgraded the risk level of this issue grade-a primary issue Highest quality submission among a set of duplicates QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#256 opened Jul 10, 2023 by code423n4
9
Long term denial of service due to lack of fees in Well 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue M-04 primary issue Highest quality submission among a set of duplicates selected for report This submission will be included/highlighted in the audit report sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
#255 opened Jul 10, 2023 by code423n4
7
Analysis analysis grade-b low quality report This report is of especially low quality
#252 opened Jul 10, 2023 by code423n4
3
Gas Optimizations bug Something isn't working G (Gas Optimization) G-05 grade-a high quality report This report is of especially high quality sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#251 opened Jul 10, 2023 by code423n4
4
QA Report bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a high quality report This report is of especially high quality Q-09 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax satisfactory satisfies C4 submission criteria; eligible for awards sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#249 opened Jul 10, 2023 by code423n4
10
Gas Optimizations bug Something isn't working G (Gas Optimization) G-06 grade-a low quality report This report is of especially low quality
#246 opened Jul 10, 2023 by code423n4
2
QA Report bug Something isn't working edited-by-warden grade-a low quality report This report is of especially low quality Q-10 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#244 opened Jul 10, 2023 by code423n4
2
ProTip! Find all open issues with in progress development work with linked:pr.