Vault.sol is not EIP-4626 compliant

[code423n4]

Lines of code

https://github.com/GenerationSoftware/pt-v5-vault/blob/b1deb5d494c25f885c34c83f014c8a855c5e2749/src/Vault.sol#L375
https://github.com/GenerationSoftware/pt-v5-vault/blob/b1deb5d494c25f885c34c83f014c8a855c5e2749/src/Vault.sol#L383

Vulnerability details

Impact

Based on the provided information, the vault is an ERC-4626 compatible vault.
The functions in Vault.sol, such as maxMint and maxDeposit, do not comply with the requirements of EIP-4626.

Other protocols that integrate with their Vault.sol may wrongly assume that the functions are EIP-4626 compliant. Thus, it might cause integration problems in the future that can lead to wide range of issues for both parties.

Proof of Concept

https://github.com/GenerationSoftware/pt-v5-vault/blob/b1deb5d494c25f885c34c83f014c8a855c5e2749/src/Vault.sol#L375
https://github.com/GenerationSoftware/pt-v5-vault/blob/b1deb5d494c25f885c34c83f014c8a855c5e2749/src/Vault.sol#L383

Tools Used

Recommended Mitigation Steps

Check the functions in Vault.sol to ensure they comply with EIP-4626.

Assessed type

ERC4626

[c4-judge]

Picodes marked the issue as duplicate of #129

[c4-judge]

Picodes changed the severity to 3 (High Risk)

[c4-judge]

Picodes changed the severity to 2 (Med Risk)

[c4-judge]

Picodes marked the issue as unsatisfactory:
Insufficient proof

[Picodes]

This report is not in my opinion up to C4's standard. Although partly valid, it doesn't explain anything. "The functions in Vault.sol, such as maxMint and maxDeposit, do not comply with the requirements of EIP-4626." -> why? Can you give an example or a PoC? The mitigation steps are also missing.