Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-06 MitigationConfirmed #13

Open
code423n4 opened this issue Aug 17, 2023 · 2 comments
Open

M-06 MitigationConfirmed #13

code423n4 opened this issue Aug 17, 2023 · 2 comments
Labels
confirmed for report This issue is confirmed for report mitigation-confirmed MR-M-06 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

Lines of code

Vulnerability details

This issue is mitigated.

Explanation of found problem

In case if RSR token should be used for trading, then it's prices are fetched using price function. This function will return low price as 0 in case if oracle is not available. Because of that, all this RSR can be sold for 0 amount in the auction.

How it was fixed

As proposed by warden, Reserve team don't use price function to fetch RSR price, but uses lotPrice only. This will make use of previously stored prices, in case of oracle timeout, which will not allow to sell RSR for 0 amount.

@c4-judge
Copy link

0xean marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Aug 28, 2023
@c4-judge
Copy link

0xean marked the issue as confirmed for report

@c4-judge c4-judge added the confirmed for report This issue is confirmed for report label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed for report This issue is confirmed for report mitigation-confirmed MR-M-06 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants