Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-09 MitigationConfirmed #16

Open
code423n4 opened this issue Aug 17, 2023 · 2 comments
Open

M-09 MitigationConfirmed #16

code423n4 opened this issue Aug 17, 2023 · 2 comments
Labels
confirmed for report This issue is confirmed for report mitigation-confirmed MR-M-09 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

Lines of code

Vulnerability details

This issue is mitigated.

Explanation of found problem

StRSR allows user unstake RSR. Later, user can cancel this request by calling cancelUnstake function. Because this function doesn't pay rewards before minting shares, that means that wrong exchange rate will be used and initiator of cancelUnstake will receive more shares, then he should and as result other stakers will lose part of rewards as they were not distributed before canceling.

How it was fixed

Reserve team fixed this issue, be calling _payoutRewards function, before minting new shares. So now exchange rate is up to date.

@c4-judge
Copy link

0xean marked the issue as satisfactory

@c4-judge c4-judge added satisfactory satisfies C4 submission criteria; eligible for awards confirmed for report This issue is confirmed for report labels Aug 28, 2023
@c4-judge
Copy link

0xean marked the issue as confirmed for report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed for report This issue is confirmed for report mitigation-confirmed MR-M-09 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants