Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-11 MitigationConfirmed #18

Open
code423n4 opened this issue Aug 17, 2023 · 1 comment
Open

M-11 MitigationConfirmed #18

code423n4 opened this issue Aug 17, 2023 · 1 comment
Labels
mitigation-confirmed MR-M-11 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

Lines of code

Vulnerability details

This issue is mitigated.

Explanation of found problem

This issue allows attacker to disable basket when unregistering of an asset that was not in the basket. It was possible to do, by gas amount manipulation. Attacker just needs to send not enough amount of gas to execute basketHandler.quantity function. This will be then caught and basket will be disabled. As result of this, basket was disabled, which paused some system actions and could lead to some unneeded trading losses.

How it was fixed

Reserve team has fixed this, by ensuring, that call was provided with enough amount of gas to be able to call basketHandler.quantity. Now it's not possible to replay attack, as code ensures, that GAS_FOR_BH_QTY amount of gas is sent with basketHandler.quantity call.

@c4-judge
Copy link

0xean marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-M-11 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants