Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M-08 MitigationConfirmed #25

Open
code423n4 opened this issue Aug 18, 2023 · 1 comment
Open

M-08 MitigationConfirmed #25

code423n4 opened this issue Aug 18, 2023 · 1 comment
Labels
mitigation-confirmed MR-M-08 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@code423n4
Copy link
Contributor

Lines of code

Vulnerability details

Comments

After the mitigation, the StRSR._payoutRewards function will not been skipped for freeze state.

There are two functions function payoutRewards() external and function stake(uint256 rsrAmount) public delete the main.frozen() check for _payoutRewards.

And calling _payoutRewards is added to the cancelUnstake function to payout rewards before updating draftRSR.
code423n4 added a commit that referenced this issue Aug 18, 2023
@code423n4
ronnyx2017 issue #25
76dbbba
@c4-judge
Copy link

0xean marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mitigation-confirmed MR-M-08 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @c4-judge