Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #56

Open
c4-submissions opened this issue Sep 27, 2023 · 4 comments
Open

QA Report #56

c4-submissions opened this issue Sep 27, 2023 · 4 comments
Labels
bug Something isn't working grade-a Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-submissions c4-submissions added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 27, 2023
c4-submissions added a commit that referenced this issue Sep 27, 2023
c4-submissions added a commit that referenced this issue Sep 27, 2023
@0xleastwood
Copy link

0xleastwood commented Oct 4, 2023

L-1 - valid
L-2 - valid
L-3 - valid
L-4 - valid
L-5 - valid
L-6 - AbstractStrategy(vEthAddress).withdraw() will revert if withdrawIdToWithdrawRequestInfo[_withdrawId].withdrawn holds true.
L-7 - valid
L-8 - valid
L-9 - valid
L-10 - should be non-critical
L-11 - same reason as L-6
L-12 - valid
L-13 - valid
L-14 - valid
L-15 - valid
L-16 - valid
L-17 - valid

NC-1 - valid
NC-2 - valid
NC-3 - valid
NC-4 - valid

INFO-1 - valid

@c4-judge
Copy link
Contributor

c4-judge commented Oct 4, 2023

0xleastwood marked the issue as grade-a

@c4-sponsor c4-sponsor added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 4, 2023
@c4-sponsor
Copy link

elmutt (sponsor) confirmed

@c4-judge
Copy link
Contributor

c4-judge commented Oct 5, 2023

0xleastwood marked the issue as selected for report

@c4-judge c4-judge added the selected for report This submission will be included/highlighted in the audit report label Oct 5, 2023
@C4-Staff C4-Staff added the Q-03 label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-a Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

5 participants