QA Report

[code423n4]

See the markdown file with the details of this report here.

[c4-pre-sort]

raymondfam marked the issue as sufficient quality report

[c4-judge]

kirk-baird marked the issue as grade-a

[ali2251]

NC-1 | ADD A TIMELOCK TO CRITICAL FUNCTIONS.
This will increase complexity and not needed for setting rate limits

NC-2 | ADD TO BLACKLIST FUNCTION
no NFTS are used anywhere in the code so this is completely irrelevant

NC-3 | GENERATE PERFECT CODE HEADERS EVERY TIME
this makes sense but doesnt add much value

NC-4 | SAME CONSTANT REDEFINED ELSEWHERE
there is one constant defined in 2 places which is absolutely fine, hence no value add

NC-5 | IMPLEMENTATION CONTRACT MAY NOT BE INITIALIZED
This is not true because initializers are disabled in the contructor

NC-6 | MARK VISIBILITY OF INITIALIZE(…) FUNCTIONS AS EXTERNAL
doesnt matter because there are no child contracts

NC-7 | CONSTANT VALUES SUCH AS A CALL TO KECCAK256(), SHOULD USE IMMUTABLE RATHER THAN CONSTANT
doesnt make sense at all, there is no reason for a deterministic function to be immutable unless it can be changed in the constructor

NC-8 | LACK OF EVENT EMISSION AFTER CRITICAL INITIALIZE() FUNCTIONS
its arguable whether it needs an event since no one uses it

NC-9 | FOR EXTENDED “USING-FOR” USAGE, USE THE LATEST PRAGMA VERSION
its not required

NC-10 | NO SAME VALUE INPUT CONTROL
doesnt make sense

NC-11 | Add parameter to event-emit
NC-12 | SOLIDITY COMPILER OPTIMIZATIONS CAN BE PROBLEMATIC
NC-13 | LINES ARE TOO LONG

as shown above, most of these issues does either not exist or are improvements that dont help security or readability

[c4-sponsor]

ali2251 (sponsor) disputed