Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-02 MitigationConfirmed #27

Open
c4-submissions opened this issue Sep 28, 2023 · 1 comment
Open

H-02 MitigationConfirmed #27

c4-submissions opened this issue Sep 28, 2023 · 1 comment
Labels
mitigation-confirmed MR-H-02 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-submissions
Copy link
Contributor

Lines of code

Vulnerability details

Lines of code

https://github.com/reserve-protocol/protocol/blob/9ee60f142f9f5c1fe8bc50eef915cf33124a534f/contracts/plugins/assets/curve/CurveVolatileCollateral.sol#L32-L65

Vulnerability details

A vulnerability was identified where the CurveVolatileCollateral contract overrides _anyDepeggedInPool() to check if the distribution of capital is balanced. As illustrated, an attacker could exploit the system by utilizing a flash loan to deposit additional USDT into the pool, subsequently marking the CurveVolatileCollateral as IFFY, and leading to potential undesired consequences on the asset pool.

Mitigation

PR #896
In response to the identified vulnerability, the sponsor made a thorough clean step and totally avoided the issue by deleting the CurveVolatileCollateral.sol file from the GitHub repository. Nevertheless, it's recommended to have a backup tracking of the de-pegging events for other intended purposes just in case.

Conclusion

The mitigation steps employed have successfully resolved the identified vulnerability concerning the flash loan attack on CurveVolatileCollateral, contributing to the overall security and integrity of the Reserve Protocol.

c4-submissions added a commit that referenced this issue Sep 28, 2023
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Oct 9, 2023
@c4-judge
Copy link

c4-judge commented Oct 9, 2023

thereksfour marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-H-02 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants