Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M-04 MitigationConfirmed #36

Open
c4-submissions opened this issue Sep 29, 2023 · 3 comments
Open

M-04 MitigationConfirmed #36

c4-submissions opened this issue Sep 29, 2023 · 3 comments
Labels
confirmed for report This issue is confirmed for report mitigation-confirmed MR-M-04 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-submissions
Copy link
Contributor

Lines of code

Vulnerability details

comments

The mitigation chooses the second Recommended Mitigation Steps from the submission.

The lastRewardBalance is changed from rewardToken.balanceOf(address(this)) to _previousBalance + deltaPerShare * _totalSupply / one. It decrease balanceAfterClaimingRewards so remainders can be used next time.

So the rewards won't be lost. The remaining rewards are only rolled over to the next call.
c4-submissions added a commit that referenced this issue Sep 29, 2023
@c4-submissions
ronnyx2017 issue #36
4400e88
@c4-judge
Copy link

c4-judge commented Oct 9, 2023

thereksfour marked the issue as unsatisfactory:
Insufficient quality

@c4-judge c4-judge closed this as completed Oct 9, 2023
@c4-judge c4-judge added the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label Oct 9, 2023
@c4-judge c4-judge reopened this Oct 11, 2023
@c4-judge c4-judge removed the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label Oct 11, 2023
@c4-judge
Copy link

thereksfour marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Oct 11, 2023
@c4-judge
Copy link

thereksfour marked the issue as confirmed for report

@c4-judge c4-judge added the confirmed for report This issue is confirmed for report label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed for report This issue is confirmed for report mitigation-confirmed MR-M-04 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c4-judge @c4-submissions