QA Report

[c4-submissions]

See the markdown file with the details of this report here.

[c4-pre-sort]

ydspa marked the issue as sufficient quality report

[c4-judge]

gzeon-c4 marked the issue as grade-b

[radeveth]

Hi, @gzeon-c4. Thank you for the quick judging!

I strongly believe that Low-01 is dup of #453.

[radeveth]

Hey, @gzeon-c4.

Please review my Low-01. It describes the same problem as #127 and #453.

So, I believe that Low-01 is dup of #127.

[gzeon-c4]

[Low-01] is a dupe of #505 which is out-of-scope

[radeveth]

[Low-01] is a dupe of #505 which is out-of-scope

Hey, @gzeon-c4!

This is not the case.

In the issue #127 writes:

An issue occurs when minContribution > maxTotalContribution - minTotalContribution.

In my Low-01 writes:

The issue arises when the difference between minTotalContribution and maxTotalContribution (the maximum allowed total contribution) is less than minContribution. This scenario creates a problematic situation for the crowdfund
https://github.com/code-423n4/2023-10-party-findings/blob/main/data/Pechenite-Q.md#:~:text=The%20issue%20arises%20when%20the%20difference%20between%20minTotalContribution%20and%20maxTotalContribution%20(the%20maximum%20allowed%20total%20contribution)%20is%20less%20than%20minContribution.%20This%20scenario%20creates%20a%20problematic%20situation%20for%20the%20crowdfund%3A

[gzeon-c4]

Low-01 failed to describe the entire issue

You also write

If contributors collectively contribute enough to meet or exceed the minTotalContribution

#127 relies on specifically pushing the contribution BELOW minTotalContribution so that the party will not be able to finalize despite host action. The issue Low-01 describe is same as https://github.com/code-423n4/2023-10-party/blob/b23c65d62a20921c709582b0b76b387f2bb9ebb5/contracts/crowdfund/ETHCrowdfundBase.sol#L247-L253 which render it out-of-scope

[radeveth]

Hey, @gzeon-c4!

My [Low-01] also relies how the Crowdfund cannot be finalize despite host actions.

As in my report write:

This situation can result in a scenario where contributors are willing to contribute enough to meet the crowdfund's minimum goal (minTotalContribution), but they are unable to do so due to the restrictive minContribution check. As a result, the crowdfund may never be successfully finalized.

The issue arises when the difference between minTotalContribution and maxTotalContribution (the maximum allowed total contribution) is less than minContribution.

—-

This part is just an explanation for the crowdfund behaviour:

If contributors collectively contribute enough to meet or exceed the minTotalContribution, the condition for finalizing the crowdfund is met.

I really don't see how my Low-01 issue isn't a duplicate of #127. 🙂

Have a good one.