Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #137

Open
c4-bot-6 opened this issue Mar 21, 2024 · 6 comments
Open

Gas Optimizations #137

c4-bot-6 opened this issue Mar 21, 2024 · 6 comments
Labels
bug Something isn't working G (Gas Optimization) G-08 grade-a high quality report This report is of especially high quality sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@c4-bot-6
Copy link
Contributor

See the markdown file with the details of this report here.
@c4-bot-6 c4-bot-6 added bug Something isn't working G (Gas Optimization) labels Mar 21, 2024
c4-bot-6 added a commit that referenced this issue Mar 21, 2024
@c4-bot-6
albahaca issue #137
e78f19a
c4-bot-6 added a commit that referenced this issue Mar 21, 2024
@c4-bot-6
albahaca data for issue #137
a5bfa77
@raymondfam
Copy link

16 well elaborate G.

@c4-pre-sort
Copy link

raymondfam marked the issue as high quality report

@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label Mar 22, 2024
@c4-sponsor c4-sponsor added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Mar 26, 2024
@c4-sponsor
Copy link

wilsoncusack (sponsor) acknowledged

@3docSec
Copy link

3docSec commented Mar 27, 2024

Many instances have been reported already by the bot:

G-01 reported by bot at L-12
G-05 reported by bot at G-48
G-06 reported by bot at N-23
G-09 reported by bot at G-37
...

@c4-judge
Copy link
Contributor

3docSec marked the issue as grade-b

@c4-judge
Copy link
Contributor

3docSec marked the issue as grade-a

@C4-Staff C4-Staff added the G-08 label Apr 1, 2024
stevieraykatz added a commit to coinbase/magic-spend that referenced this issue Apr 4, 2024
@stevieraykatz
Reorder validations in withdraw to check signature before validating …
88e7d9c 
…the full request. Per code-423n4/2024-03-coinbase-findings#137 G02
@stevieraykatz stevieraykatz mentioned this issue Apr 4, 2024
Merged
stevieraykatz added a commit to coinbase/magic-spend that referenced this issue Apr 4, 2024
@stevieraykatz
Gas optimizations from the Code4rena audit (#18)
8592b5f 
* Check that withdrawAmt > maxCost before updating mapping. Per code-423n4/2024-03-coinbase-findings#195, G04

* Switch validation checks for gas optimization. Per code-423n4/2024-03-coinbase-findings#195 G06

* Reorder validations in withdraw to check signature before validating the full request. Per code-423n4/2024-03-coinbase-findings#137 G02

* Added gas snapshot

* Formatted

* Remove balance check before updating withdrawable mapping, rerun snapshot
@c4-bot-5 c4-bot-5 mentioned this issue Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) G-08 grade-a high quality report This report is of especially high quality sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@raymondfam @c4-judge @c4-sponsor @c4-pre-sort @C4-Staff @c4-bot-6 @3docSec