Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #143

Open
c4-bot-2 opened this issue Mar 21, 2024 · 5 comments
Open

Gas Optimizations #143

c4-bot-2 opened this issue Mar 21, 2024 · 5 comments
Labels
bug Something isn't working G (Gas Optimization) G-07 grade-a sufficient quality report This report is of sufficient quality

Comments

@c4-bot-2
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-bot-2 c4-bot-2 added bug Something isn't working G (Gas Optimization) labels Mar 21, 2024
c4-bot-1 added a commit that referenced this issue Mar 21, 2024
c4-bot-2 added a commit that referenced this issue Mar 21, 2024
@raymondfam
Copy link

4 well elaborate G.

@c4-pre-sort
Copy link

raymondfam marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Mar 22, 2024
@c4-judge
Copy link
Contributor

3docSec marked the issue as grade-a

@thenua3bhai
Copy link

Hi @3docSec Thanks for judging.
Flagging this since this report is of low quality ,I think this report should not be grade-a. When comparing with other grade-a reports specially with high quality ones.
Since they saves significant gas savings with higher number of good findings
Whilethis report only reported 4 trivial findings out of which G-01 and G-03 also reported by bot. Only two valid findings which are also much less savers.
G-01 Using calldata instead of memory for read-only arguments
G-02 Using XOR (^) and AND (&) bitwise equivalents
G-03 Use assembly to check for address(0)
G-04 Revert Transaction as soon as possible

So only consists two valid findings which are also trivial and less gas saver. So comparing this 2 valid finding report with other high qulaity gas reports this should be considered as grade-c or max to max b definitely not grade-a. Please re-consider this report grade.
Thanks.

@3docSec
Copy link

3docSec commented Mar 29, 2024

Thanks for bringing this up, I will consider your point.

@C4-Staff C4-Staff added the G-07 label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) G-07 grade-a sufficient quality report This report is of sufficient quality
Projects
None yet
Development

No branches or pull requests

7 participants