Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All owners can be removed by an owner, which bricks the CoinbaseSmartWallet #51

Open
c4-bot-2 opened this issue Mar 19, 2024 · 7 comments
Open

All owners can be removed by an owner, which bricks the CoinbaseSmartWallet #51

c4-bot-2 opened this issue Mar 19, 2024 · 7 comments
Labels
bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-181 grade-a insufficient quality report This report is not of sufficient quality Q-22 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax 🤖_08_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-2
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2024-03-coinbase/blob/main/src/SmartWallet/MultiOwnable.sol#L102-L110

Vulnerability details

Impact

Any owner can delete all owners by repeatedly calling removeOwnerAtIndex().
Once all owners are removed the CoinbaseSmartWallet can't be used anymore and is bricked.

Proof of Concept

Repeatedly call removeOwnerAtIndex()

Tools Used

Manual review

Recommended Mitigation Steps

Consider checking at least one owner is left
(e.g. don't allow the last owner to be removed)
Alternatively don't allow any owner to remove himself.

Assessed type

Governance
@c4-bot-2 c4-bot-2 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Mar 19, 2024
c4-bot-2 added a commit that referenced this issue Mar 19, 2024
@c4-bot-2
gpersoon issue #51
73bdca8
@c4-bot-13 c4-bot-13 added the 🤖_08_group AI based duplicate group recommendation label Mar 21, 2024
@c4-pre-sort
Copy link

raymondfam marked the issue as insufficient quality report

@c4-pre-sort c4-pre-sort added the insufficient quality report This report is not of sufficient quality label Mar 21, 2024
@raymondfam
Copy link

Inadequate description of the issue.

@c4-pre-sort
Copy link

raymondfam marked the issue as duplicate of #18

@c4-pre-sort
Copy link

raymondfam marked the issue as duplicate of #22

@c4-pre-sort
Copy link

raymondfam marked the issue as duplicate of #181

@c4-judge
Copy link
Contributor

3docSec marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Mar 27, 2024
@c4-judge
Copy link
Contributor

3docSec changed the severity to QA (Quality Assurance)

@c4-judge c4-judge added downgraded by judge Judge downgraded the risk level of this issue QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Mar 27, 2024
@C4-Staff C4-Staff reopened this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-181 grade-a insufficient quality report This report is not of sufficient quality Q-22 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax 🤖_08_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@raymondfam @c4-judge @c4-pre-sort @C4-Staff @c4-bot-2 @c4-bot-13