Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD-02 MitigationConfirmed #11

Open
c4-bot-2 opened this issue Apr 10, 2024 · 1 comment
Open

ADD-02 MitigationConfirmed #11

c4-bot-2 opened this issue Apr 10, 2024 · 1 comment
Labels
mitigation-confirmed MR-ADD-02 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-2
Copy link
Contributor

Lines of code

Vulnerability details

C4 Issue

QA 38 : unchecked loop increments no valid in solidity > v0.8.22

G01 : Update storage variable once outside of the loop instead of updating it every time in loop it saves 1 SSTORE, 1SLOAD per iteration(Saves ~2200 Gas per iteration)

G03 : Call _getMultiOwnableStorage() one time to fetch storage pointer and avoid extra internal function call

G09 : Do not assign a variable with its default value

Mitigation

Gas optimization are correctly implemented as suggested.

From the difference in gas snapshot there is a slightly decrease of gas usage for the patched version which is to be expected.

Conclusions

Successful Mitigation

c4-bot-7 added a commit that referenced this issue Apr 10, 2024
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Apr 11, 2024
@c4-judge
Copy link

3docSec marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-ADD-02 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants