Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD-02 MitigationConfirmed #2

Open
c4-bot-6 opened this issue Apr 10, 2024 · 1 comment
Open

ADD-02 MitigationConfirmed #2

c4-bot-6 opened this issue Apr 10, 2024 · 1 comment
Labels
mitigation-confirmed MR-ADD-02 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-6
Copy link
Contributor

Lines of code

Vulnerability details

Comments

  1. Simple change to iterator incrementation method in CoinbaseSmartWallet::executeBatch.
  2. Replaces MultiOwnable::_addOwner with _addOwnerAtIndex
  3. Cache nextOwnerIndex in MutliOwnable::_initializeOwners rather than read from storage in each loop iteration.
  4. Cache _getMultiOwnableStorage() in MultiOwnable::_initializeOwners to avoid having to call it twice.

Conclusion

LGTM
c4-bot-8 added a commit that referenced this issue Apr 10, 2024
@c4-bot-8
McToady issue #2
e9a0bd9
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Apr 11, 2024
@c4-judge
Copy link

3docSec marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mitigation-confirmed MR-ADD-02 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c4-judge @c4-bot-6