Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Q -> 2 from #892 [1715425381801] #1310

Closed
c4-judge opened this issue May 11, 2024 · 2 comments
Closed

Upgraded Q -> 2 from #892 [1715425381801] #1310

c4-judge opened this issue May 11, 2024 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate-118 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-judge
Copy link
Contributor

Judge has assessed an item in Issue #892 as 2 risk. The relevant finding follows:

[L-1] Griefing is possible on vault removal
In VaultManagerV2.sol line 101 Since anyone can deposit into a vault, someone can deny removal of a vault if will be able to frontrun removal transaction with a 1 wei deposit. However, this is rated as low at best, since this doesn’t look like efficient and impactful attack vector.

Remediation:
Either allow owner to pause deposits or implement minimum deposit to make attack more expensive.

@c4-judge c4-judge added the 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value label May 11, 2024
c4-judge added a commit that referenced this issue May 11, 2024
@c4-judge
Copy link
Contributor Author

koolexcrypto marked the issue as duplicate of #118

@c4-judge
Copy link
Contributor Author

koolexcrypto marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate-118 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

1 participant