Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move contest.csv calls to api #6203

Merged
merged 43 commits into from
Jan 24, 2023
Merged

Move contest.csv calls to api #6203

merged 43 commits into from
Jan 24, 2023

Conversation

hannahtuttle
Copy link
Contributor

This is waiting until the contest data is moved into Moralis.

@hannahtuttle hannahtuttle self-assigned this Dec 20, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 20, 2022 •
edited
Loading

✅ code4rena.com deploy preview ready

Simon-Busch
Simon-Busch reviewed Jan 9, 2023
View reviewed changes
api/getData.ts Outdated Show resolved Hide resolved
_data/handles/moksha.json Outdated Show resolved Hide resolved
netlify/functions/leaderboard.ts
@@ -23,7 +24,7 @@ const getLeaderboardResults = async (
handle?: string
) => {
// @TODO: also filter by contestId (if provided)
const allContests = (await csv().fromFile("_data/contests/contests.csv"))
const allContests = (await getApiContestData())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here we are making the API call instead of using the graph for example, so I am not sure we need to feed the graph.

netlify/util/contest-utils.ts Outdated Show resolved Hide resolved
gatsby-node.esm.js Outdated Show resolved Hide resolved
Simon-Busch
Simon-Busch reviewed Jan 11, 2023
View reviewed changes
bin/validate.js Outdated Show resolved Hide resolved
@Simon-Busch
Copy link
Contributor

@joshuashort Would like to have your opinion on this commit .

As the contest data will come from the API from now on, I suggest removing the check for contests in validate.js. Would it makes sense to you?

@joshuashort
Copy link
Contributor

@joshuashort Would like to have your opinion on this commit .

As the contest data will come from the API from now on, I suggest removing the check for contests in validate.js. Would it makes sense to you?

Yeah, agree in principle. If we still need to validate the contest csv, that’d have to move to its new home (a _data repo or directly in the API).

But disabling validation here is gonna be needed.

@Simon-Busch Simon-Busch changed the title WIP : move contest.csv calls to api Move contest.csv calls to api Jan 12, 2023
@hannahtuttle hannahtuttle merged commit 7c44014 into main Jan 24, 2023
@Simon-Busch Simon-Busch deleted the nighthawk/move-contest-calls-to-api branch January 24, 2023 15:45
@hannahtuttle hannahtuttle mentioned this pull request Jan 24, 2023
Merged
@hannahtuttle hannahtuttle restored the nighthawk/move-contest-calls-to-api branch January 24, 2023 16:51
@natevw natevw mentioned this pull request Mar 3, 2023
Open
@natevw natevw mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simon-Busch Simon-Busch Simon-Busch approved these changes

Assignees

@hannahtuttle hannahtuttle

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hannahtuttle @Simon-Busch @joshuashort