Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity standardization - NFT metadata #109

Open
KuTuGu opened this issue Jul 6, 2023 · 4 comments
Open

Severity standardization - NFT metadata #109

KuTuGu opened this issue Jul 6, 2023 · 4 comments

Comments

@KuTuGu
Copy link

KuTuGu commented Jul 6, 2023

We don't seem to have a standard severity of NFT metadata, so I created the issue to discuss.
There are two main problems:

  1. The Metadata JSON hard-coded data is bypassed and overwritten
  1. Insert script into the SVG data and run any command

The focus is on whether this issue should be filtered by the front end or the smart contract.

Welcome to discuss and supplement the case.

@gzeoneth
Copy link
Member

gzeoneth commented Jul 6, 2023

As commented in one of the issue, I don't see them having high/med security impact because sanitation should be done by the frontend, which on its own can also inject malicious script. It also required privileged role to set those data in the Llama case.

@KuTuGu
Copy link
Author

KuTuGu commented Jul 6, 2023

To clarify, in Llama anyone can deploy a DAO, set up malicious data in DAO NFT, and launch an attack as long as someone else loads NFT image in the web page, such as browsing NFTs in opensea.

@gzeoneth
Copy link
Member

gzeoneth commented Jul 6, 2023

To clarify, in Llama anyone can deploy a DAO, set up malicious data in DAO NFT, and launch an attack as long as someone else loads NFT image in the web page, such as browsing NFTs in opensea.

Anyone can also deploy any smart contract or NFT too, I am sure OpenSea would not assume the tokenURI is safe.

@GalloDaSballo
Copy link

I also side with QA unless the Web Part of the site was in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants