Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont depend on LocalStorage to work in Incognito mode (Volume shortcut & normalization & Pixel positions: Improvedtube Icon & Custom Mini Player) #1408

Open
BigBagss opened this issue Sep 9, 2022 · 1 comment
Labels
Bug Bug or required update after YouTube changes Completition / Revision Rethink, complete, improve, tweak our feature or structure. help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@BigBagss
Copy link

BigBagss commented Sep 9, 2022

PROBLEM:
The Custom Mini Player doesn't remember it's position while incognito / has weird default position.

By Default / While Incognito:
incognito
Normal (the position which i set it to):
normal

SOLUTION:
Make The Custom Mini Player Remember it's position even while Incognito.

SHORT Table (Summary)
Problem The Custom Mini Player doesn't remember it's position while incognito
Solution Make The Custom Mini Player Remember it's position even while Incognito.

Thank you very much 👍👍👍


i also noticed these errors in console:

this error shows once. after page load basically
error

and this error shows when clicking keybinds (keybind pressed for this picture: Volume Down):
keybindError

i don't really mind if the keybinds don't work on iframes.

@BigBagss BigBagss added Feature request Wish or idea help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Sep 9, 2022
@ImprovedTube ImprovedTube added the Bug Bug or required update after YouTube changes label Sep 29, 2022
@ImprovedTube ImprovedTube added Completition / Revision Rethink, complete, improve, tweak our feature or structure. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ and removed Feature request Wish or idea labels Apr 6, 2023
@ImprovedTube ImprovedTube changed the title Custom Mini Player doesn't remember it's position while incognito Custom Mini Player & Improvedtube Icon don't t remember position in incognito. Same for volume shortcut & normalization Apr 6, 2023
@ImprovedTube ImprovedTube changed the title Custom Mini Player & Improvedtube Icon don't t remember position in incognito. Same for volume shortcut & normalization Incognito window: Custom Mini Player & Improvedtube Icon don't t remember position in Same for volume shortcut & normalization Apr 6, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 6, 2023

Currently depending on "localStorage" & unavailable in incognito mode:

https://github.com/search?q=repo%3Acode-charity%2Fyoutube%20localstorage&type=code

  • Drag&Drop position of custom Miniplayer & ImprovedTube icon position

  • Volume Shortcut

  • Volume normalization

might be efficient to fix in one go /for whom has done such before.
/check our messaging with website-context & the status.storage functions

@ImprovedTube ImprovedTube added up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ and removed up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Apr 29, 2023
@ImprovedTube ImprovedTube changed the title Incognito window: Custom Mini Player & Improvedtube Icon don't t remember position in Same for volume shortcut & normalization Incognito window: Local storage not avaiable. Breaks volume shortcut & normalization. And Custom Mini Player & Improvedtube Icon positions. Sep 4, 2023
@ImprovedTube ImprovedTube changed the title Incognito window: Local storage not avaiable. Breaks volume shortcut & normalization. And Custom Mini Player & Improvedtube Icon positions. Dont depend on LocalStorage to work in Incognito mode (Volume shortcut & normalization & Pixel positions: Improvedtube Icon & Custom Mini Player) Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes Completition / Revision Rethink, complete, improve, tweak our feature or structure. help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants