Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume above 100% AND no normalization combined? #1821

Open
Anoaxx opened this issue Nov 8, 2023 · 11 comments
Open

volume above 100% AND no normalization combined? #1821

Anoaxx opened this issue Nov 8, 2023 · 11 comments
Assignees
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Anoaxx
Copy link

Anoaxx commented Nov 8, 2023

its very simple, just add option to go louder then 100% if u use "forced volume" options u can allow that as seperate option.

PS. WELCOME BACK! <3

@Anoaxx Anoaxx added Feature request Wish or idea help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Nov 8, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 8, 2023

hi!!

besides that this feature still needs an update (or is it working for you still?)

@Anoaxx
Copy link
Author

Anoaxx commented Nov 9, 2023

im not using it cause i have other extension that works everywhere in browser

@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes Completition / Revision Rethink, complete, improve, tweak our feature or structure. and removed Feature request Wish or idea labels Nov 10, 2023
@drewduong
Copy link

I'd like to contribute!

@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 20, 2023

hi! @drewduong awesome!

@ImprovedTube
Copy link
Member

#1085 (comment)

#1499 #1382

@raingart
Copy link

The only native way to use createMediaElementSource, .createGain() to increase the amplitude of the level sampling results in "overloading" and distortion of the sound.
It’s easier to specify in the “loudness normalization” parameter that it allows you to significantly increase the volume. No loss of quality. Since youtube lowers the video volume by 2 times for its own function of averaging the player’s volume level

like: Volume loudness normalization (Boost volume level)

@drewduong
Copy link

That's a really good point

@grlscz
Copy link

grlscz commented Dec 9, 2023

Hi!

Just tried this extension to fix volume of a very quiet video. Found forced volume slider which goes to 400 but doesn't seem to actually do anything above 100. And loudness normalization option which also doesn't seem to affect volume in any way.

Firefox. Windows 10.

Uninstalled, found "Volume control" extension - works as expected.

@GKid94
Copy link

GKid94 commented Jan 29, 2024

It would be great to have a boost volume option

@ImprovedTube
Copy link
Member

ImprovedTube commented Jan 29, 2024

hi @drewduong! did you start? will soon?


The only native way to use createMediaElementSource, .createGain() to increase the amplitude of the level sampling results in "overloading" and distortion of the sound.
It’s easier to specify in the “loudness normalization” parameter that it allows you to significantly increase the volume. No loss of quality. Since youtube lowers the video volume by 2 times for its own function of averaging the player’s volume level

  • So for example, if the user sets a boost of 100% for a video that YouTube normalize to 0.6 usually, then we'd only need to disable YouTube's normalization for that video and add another 20% of boost?
    • besides if a user will use both, boost and our toggle to always disable YouTube's normalization - consequently all we can do is apply boost. (besides i am not sure how may people even want this & why)

2 times

  • So that by a 'traffic light indication', in our slider the range between 100%-200% could be marked up as a gradient from green to yellow. While only the boost above 200% would always have to a gradient from yellow to red.
    • What's the average YouTube plays? ( 0.75? ) @raingart
    • ,whereas for each current videos there only is one break point where overdrive starts. Which could be indicated in our permanent volume slider too as ↑"this video" .
      • ,whereas we can also show the possible boost by lengthening the volume slider in YouTube's player. While the native boose can look almost the same and only the "overdrive" (gain) could be marked up with a faint red (compare UI ideas: <video> Player buttons to be added</video> #1445).

@grlscz thats why i changed the label to bug (/more precisely: outdated)

im not using it cause i have other extension that works everywhere in browser

(we should already run for all player (permission can be optional). limiting our effort to run on YouTube only makes no sense. compare #1881. @Anoaxx @grlscz )

@ImprovedTube ImprovedTube removed the Bug Bug or required update after YouTube changes label Jan 31, 2024
@ImprovedTube ImprovedTube changed the title Option: Allow volume above 100% volume above 100% AND no normalization combined? Jan 31, 2024
@ImprovedTube
Copy link
Member

ImprovedTube commented Feb 10, 2024

This tampermonkey userscript was the only thing I found that worked somewhat, but it usually needed a page refresh to catch, i.e. not applicable in practice.

@raingart, so you know about normalization?


To-Do: #1085 (comment)
(bugs: #1896 #1408 #1922 )

youtube's built-in loudness normalization (which due to a long standing bug in Firefox on Linux changes the application volume in the system mixer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

6 participants