4.6 seems to break middle click (auto scroll) scrolling on Firefox

[PoorChameleon]

Bug Report:

⚬ BUG: Updating to 4.6 breaks autoscrolling, so pressing middle click and trying to scroll that way, on Firefox

⚬ HOW: Install 4.6 and try to middle click scroll on any (but especially video) page

⚬ EXPECTED (/preferred) behavior: For middle click scroll to work as expected

⚬ Context: This worked just fine on 4.0.17.1, however it also works on 4.4 so it might be a change between 4.4 and 4.6. On Chrome middle click scrolling works on 4.6 so this might be Firefox specific

Setup:

⚬ ImprovedTube Version: 4.6
⚬ Browser: Firefox 111.0.1
⚬ Settings: Happens on fresh install too
⚬ OS: Windows 11

I hope this isn't something specific to my setup, but I did try with a fresh portable version of Firefox and the addon

Edit2: if you navigate backwards from a video back to a channel you can middle click scroll for like half a second before it stops so it seems as soon as something loads it breaks

Edit3: it seems to always break most consistently when opening a video in a new tab

[debdrup]

Even if it took me a while to figure out that it's this add-on that's responsible, I can confirm that I'm also experiencing this issue.

So I'll be keeping an eye on the thread. :)

[ChristophSchmidpeter]

I hope this isn't something specific to my setup, but I did try with a fresh portable version of Firefox and the addon

Reproducible here as well

[ImprovedTube]

specific to firefox :D got it too.

[ImprovedTube]

amazed about the activity here though
google results:

 20 000 000 000x  click 
    120 000 000x "right click"   
        700 000x "middle click"

[ImprovedTube]

@ChristophSchmidpeter @debdrup
Since @PoorChameleon narrowed it down, there remain only these few commits (none of which seems critical 😀)

So we have to try one by one
(besides of course you can can skip edits of readme, .gitmodules)

https://github.com/code-charity/youtube/commits/424d609b14da9479f38db42795e474ca2ba75771

[PoorChameleon]

I believe 4556fb0 is the commit that breaks auto scrolling on Firefox. It still works on the earlier dbb3ed0 commit

[ImprovedTube]

thanks, reporting to Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1827288

[ImprovedTube]

Firefox gave it a normal priority and said it might be fixed
hi @greenhouse95 @raszpl
this line started as a fix/precaution for the transcript feature, but also makes YouTube's page load more calm

youtube/js&css/extension/www.youtube.com/appearance/sidebar/sidebar.css

Lines 1 to 5 in a0d5fe7

	html {overflow-x: hidden !important; }
	/* Fix to tame Youtube's page-load / make it more calm - the player wont annoyingly slide in from the right anymore */
	/* previously also: html[it-transcript='true'] {overflow-x: hidden !important; } */
	@-moz-document url-prefix() { overflow-x: visible !important; } /* REMOVE ME SOON https://github.com/code-charity/youtube/issues/1649 */

in the meantime i can manually delete or overwrite it in the next firefox version ( @-moz-document url-prefix() { overflow-x: visible !important; } )

however the gain might outweight the loss, unless there is high correlation between ImprovedTube users in Firefox & Middle Click users (and Github Reporters)

20 000 000 000x click
120 000 000x "right click"
700 000x "middle click"

( Such amazing correlation seems to be proven since you are nr 4. reporting @greenhouse95.
isnt Middle click usually less comfortable than ctrl+click? 🤔 (depending what mouse) )

[PoorChameleon]

Hey, so it breaks again on the latest version, assuming since the change you temporarily made was reverted.

If it's too much maintenance to have middle click scrolling then it's okay, but it would be nice to have it working on Firefox.

[greenhouse95]

Hey, so it breaks again on the latest version, assuming since the change you temporarily made was reverted.

If it's too much maintenance to have middle click scrolling then it's okay, but it would be nice to have it working on Firefox.

Yeah I don't feel like it will ever get fixed from either side (Firefox and Extension). So what I've done myself is use the Stylus extension to create a style, with this line: html[style]{overflow-x: visible !important; }
That will override the extension change that breaks the scrolling.

[gregmatic]

Hey, so it breaks again on the latest version, assuming since the change you temporarily made was reverted.
If it's too much maintenance to have middle click scrolling then it's okay, but it would be nice to have it working on Firefox.

Yeah I don't feel like it will ever get fixed from either side (Firefox and Extension). So what I've done myself is use the Stylus extension to create a style, with this line: html[style]{overflow-x: visible !important; } That will override the extension change that breaks the scrolling.

beautiful.

[greenhouse95]

@-moz-document url-prefix() { overflow-x: visible !important; }

so this isnt taking effect?

It did work until it was removed on this commit.

[KSneijders]

@ImprovedTube Can the removal of what's shown above be reverted? It's still broken

[ImprovedTube]

hi @KSneijders! yes, you can try it
c0af89c

https://github.com/code-charity/youtube/archive/refs/heads/master.zip

(of course the most efficient would be a build script, just removing the html {overflow-x: hidden !important;} from the firefox version and already predicting until when that's good )

[KSneijders]

Hey @ImprovedTube, I tried it by loading the zip file as Temporary Extension in Firefox and the auto scroll works again!

I didn't quite understand what you meant with the sentence "(of course the most efficient... ...until when that's good)". So I'll ask this just in case, will this change be released in the next update by any chance? 🙂

Thanks for the quick update and the plugin in general! ❤️

[ImprovedTube]

hi @KSneijders thanks

released

can be released, until firefox might also fix it.

understand

(currently the gihub repo version is the same in all browsers, until we may use a build.py again to make the edits each browsers needs. yet running a line of CSS shouln't take relevant CPU time even for everybody in sum.)

[ImprovedTube]

• RE: v4.443 : Firefox not Scrolling with Middle Mouse Button  #1875
  - What about the previous version/s - welcome @itsLantik!

v4.443 moved the line here from general.css. That might just makes it run slightly earlier?

youtube/js&css/extension/www.youtube.com/styles.css

Lines 1 to 8 in 0e38a2a

	/* fix for youtube's player moving in from the right side */
	html {overflow-x: hidden !important; }
	/* html {overflow-x: hidden !important; }
	/* Fix to tame Youtube's page-load / make it more calm - the player wont annoyingly slide in from the right anymore */
	/* previously also: html[it-transcript='true'] {overflow-x: hidden !important; }*/
	@-moz-document url-prefix() { overflow-x: visible !important; } /* REMOVE ME SOON https://github.com/code-charity/youtube/issues/1649
	/*------------------------------------------------------------------------------
	>>> TABLE OF CONTENTS:

hi @KSneijders @greenhouse95

[Onsekyl]

The fix presented here works only for the first tab of Youtube, if I open another one it doesn't work there but keeps working on the first one. Closing all tabs and opening them again produces same thing.

I'm pretty much clueless about how these things work so don't know if this is relevant, just pointing it out.

[itsLantik]

@Onsekyl Yeah I got the same first tab issue, an improvement nonetheless. I would recommend looking for "Enhancer for Youtube", it's not on the Firefox Addons store anymore but you can find a zip online. It's not perfect but until this gets fixed it's a good patchwork solution.

[ImprovedTube]

hi! @itsLantik @Onsekyl, confusing. you can try to remove the lines above from FireFox completely.

• download the repo https://github.com/code-for-charity/ImprovedTube-for-YouTube/archive/refs/heads/master.zip
  remove the lines mentioned and then load it unpacked in firefox meant for temporary debugging.
  thanks

[Onsekyl]

@ImprovedTube @itsLantik That worked! The scroll works now. To itsLantik: I recently moved from the Enchanger for Youtube as it began to malfunction too much.

[Onsekyl]

Hi, I noticed that if you press the middle mouse on top of the scrollbar the fast scroll works!

[ImprovedTube]

hi! @Onsekyl thanks! (we can also fixing simply removing (if not fixing) the first few lines of our styles.css for firefox.)

[ImprovedTube]

@-moz-document url-prefix() { overflow-x: visible !important; }

sorry this was missing html{ }

latest.zip

also #2254