Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject embed/ always use embed popout player #1727

Open
Chaython opened this issue Aug 4, 2023 · 1 comment
Open

inject embed/ always use embed popout player #1727

Chaython opened this issue Aug 4, 2023 · 1 comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Chaython
Copy link

Chaython commented Aug 4, 2023

PROBLEM:
image

SOLUTION: Embeds don't seem to give this error message, so why not replace native content with embed?

ALTERNATIVES:

RELEVANCE / SCOPE: Everybody who uses adblock

"SIDE EFFECTS": Some channels have embed disabled

CONTEXT:
//
Thank you!

SHORT Table (Summary)
Problem
Solution
Alternatives
Scope
Side effects
Context
@Chaython Chaython added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Aug 4, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Aug 7, 2023

hi @Chaython,
when did this start? (what about ublock origin? Adblock for youtube? Our adskipper?)
is there an official statement by youtube why embedding might be spared?


embedding will also allow a light theme #1211
(we can research which of the top 5000 channels disallow it ( #1451 #514 ) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants