Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theater mode has broken again #1740

Closed
alidan opened this issue Aug 17, 2023 · 27 comments
Closed

Theater mode has broken again #1740

alidan opened this issue Aug 17, 2023 · 27 comments
Assignees
Labels
Bug Bug or required update after YouTube changes important Critical? (bad or common issue) Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction

Comments

@alidan
Copy link

alidan commented Aug 17, 2023

so thearter mode broke

then there was a fix with stylish

now that's broke as well, still works on firefox, but not chrome

is there any way, third party extension, script, I don't care, that enables the blacked out surrounding for videos, I hate having 1//4 of my screen be completely discracting.

@Sturmx88
Copy link

Sturmx88 commented Aug 18, 2023

Firefox is broken now as well. It did work yesterday.

@shengziekillz
Copy link

shengziekillz commented Aug 18, 2023

firefox with stylish fix is broken too

Uploading image.png…

@jamescl131
Copy link

Yep, same for me in Chrome, it was working perfectly since this issue was fixed at the start of July, until today.

@Essoje
Copy link

Essoje commented Aug 18, 2023

Temporary fix with stylish.

@-moz-document url-prefix("https://www.youtube.com/watch?v=") {
    ytd-watch-flexy[theater] #player-full-bleed-container.ytd-watch-flexy {
        height: 100vh !important;
        max-height: none !important;
    }
}

There was a change from player-wide-container to player-full-bleed-container.

@shengziekillz
Copy link

oh didnt know that its working again with that fix hehe

@alidan
Copy link
Author

alidan commented Aug 18, 2023

fixed for now, thank you. at some point between me makeing the post and this one, the old way was working again, and then it stopped prompting me to check email to see if anyone responded... again thank you.

@andycjw
Copy link

andycjw commented Aug 19, 2023

is there stylish fix or similar for non firefox browser?

@anandnarla
Copy link

if you have ublock origin you can use the following filter

youtube.com##ytd-watch-flexy[theater] #player-full-bleed-container.ytd-watch-flexy:style( height: 100vh!important; max-height: none!important; )

@mahadi22
Copy link

mahadi22 commented Aug 19, 2023

Manual Way for Opera/Opera One,
trying to help manual way editing extension file, if you use opera/opera one browser and chrome extension, you can edit the extension file on

%AppData%\Opera Software\Opera Stable\Extensions\bnomihfieiccainjcjblhegjgglakjdd\4.28_0\js&css\extension\www.youtube.com\appearance\player

with opera browser closed, edit player.css file with notepad/notepad++

and change player-wide-container to player-full-bleed-container

@Birphon
Copy link

Birphon commented Aug 19, 2023

Temporary fix with stylish.

@-moz-document url-prefix("https://www.youtube.com/watch?v=") {
    ytd-watch-flexy[theater] #player-full-bleed-container.ytd-watch-flexy {
        height: 100vh !important;
        max-height: none !important;
    }
}

There was a change from player-wide-container to player-full-bleed-container.

This works wonderfully. Weirdly I had one with out the @-moz line from June 29 in which another person gave a Stylish code (i made a "tutorial" reply on how to use it here ) but weirdly enough I had to delete that Stylish and make a new one, wasn't something I could edit and be done with. Edit: reading is really hard for me, didn't see the "change from" line Essoje put lol

I am an OperaGX so Stylish does work for Chromium based browsers as well which you can find the Stylus download here.

Steps for those that need it:

Step 1: Click on the Stylus Extension Icon in your Extension's Bar and Click on Manage
image_2023-08-19_202412047

Step 2: Left side of this tab click on New Style
image

Step 3: Paste Essoje's Style Code.
Select Override on this one
image

Step 4: Give name and Save
image

Step 5: Refresh the YouTube tab
You may need to refresh it a couple of time or open and close

@HenryLoenwind
Copy link

is there stylish fix or similar for non firefox browser?

You can just use the inner part without the outer code that limits it affecting only YouTube:

ytd-watch-flexy[theater] #player-full-bleed-container.ytd-watch-flexy {
        height: 100vh !important;
        max-height: none !important;
}

I doubt any other website uses those class names with "ytd" in them anyway.

And to inject this, there are plenty of CSS inserter extensions (for example, Stylebot). Most of them already limit the CSS to the site you entered it for, which makes the outer block double unnecessary.

@Birphon
Copy link

Birphon commented Aug 19, 2023

now here's a possible issue with how the player gets changed which could be another bug report but could be because of how we use Stylus (or other) to change the player, im noticing that i have to scroll up. Like if you make a theatre mode video and then scroll 1 tick down so you see the title and 1/2 of the channel name, thats whats happening.

@AshleighAdams
Copy link

Does anyone have a uBlock Origin filter that works for Chrome?

@mahadi22
Copy link

Does anyone have a uBlock Origin filter that works for Chrome?

filter by anandnarla are working on chrome and opera

@AshleighAdams
Copy link

@mahadi22 thanks, my bad on missing the prior comment

@Remco32
Copy link

Remco32 commented Aug 22, 2023

Seems to have broken again on my end, using the CSS fixes provided in this thread.

@PoorChameleon
Copy link

PoorChameleon commented Aug 22, 2023

Here's a new fix. If you have the extension installed it's recommended to use size variables so it calculates the player size correctly depending if you have the header enabled or not.

If not, you can just use the 100vh etc.

ytd-watch-flexy[full-bleed-player]:not([fullscreen]) #full-bleed-container.ytd-watch-flexy {
  height: calc(var(--it-player-size) - var(--it-header-size)) !important;
  max-height: var(--it-player-size) !important;
}

@Remco32
Copy link

Remco32 commented Aug 22, 2023

You can try using this as a selector

ytd-watch-flexy[full-bleed-player]:not([fullscreen]) #full-bleed-container.ytd-watch-flexy

I changed my Stylish script to this, which seems to work

ytd-watch-flexy[full-bleed-player]:not([fullscreen]) #full-bleed-container.ytd-watch-flexy {

        height: 100vh !important;
        max-height: none !important;
    }

@alidan
Copy link
Author

alidan commented Aug 22, 2023

just made a new style with that exactly, it worked, again thanks.

for the developer, because this keeps happening, may I suggest a part of the extention just be a user copy pasteable section for what currently works so that we can put it in place immediately, and over time when a new version comes out it can fall back to the built in way till it again needs a user fixing?

@suparnaghosh934
Copy link

suparnaghosh934 commented Aug 22, 2023 via email

@AshleighAdams
Copy link

The new full uBlock filter using the above snippet is:

youtube.com##ytd-watch-flexy[full-bleed-player]:not([fullscreen]) #full-bleed-container.ytd-watch-flexy:style( height: 100vh!important; max-height: none!important; )

@ImprovedTube
Copy link
Member

hi guys! while i often can't, the project actually deserves to make these fixes on the same day (mostly) always (who if not us!)
please join us.

@jamescl131
Copy link

The extension was updated today and it is working well. Thanks

@ImprovedTube
Copy link
Member

@jamescl131 and we might fix the other bugs with video quality & size features, after the same youtube updates, hopefully very soon. - Or it might finally be time to invite every user to github?

@PoorChameleon
Copy link

* We can upgrade some features to more regular CSS path selectors -  predicting some of the future....

* We can get hosted "config files"  to everybody could fix it with out permission, or at least the whole team on github.  (compare https://github.com/darkreader/darkreader/tree/main/src/config )
  
  * _(Only remote JS might disppear, if  "Manifest3" ever goes through (after looming /spooking extension developers these years)
    https://developer.chrome.com/docs/extensions/mv3/intro/mv3-overview/
    https://stackoverflow.com/questions/68322392/chrome-extension-manifest-v3-remotely-hosted-code_ )

If this is implemented I'll at least mildly volunteer to update the theater mode whenever or if it becomes broken. No clue what to do with manifest v3 implementation though

@AshleighAdams
Copy link

@ImprovedTube Does the Firefox extension need to be updated/is there a beta channel for it? It looks like the last update was August 9?

@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 6, 2023

@AshleighAdams sometimes firefox takes a few days, then, if we upload another fix already, the firefox extension version history might skip one.

@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes important Critical? (bad or common issue) Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction labels Sep 6, 2023
ImprovedTube added a commit that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes important Critical? (bad or common issue) Knowledge Base / Dokumenation for developers We should repurpose this for future reference / Wiki / Education / Introduction
Projects
None yet
Development

No branches or pull requests