Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening search results in new tab setting #1774

Closed
asdeepasthepasific opened this issue Sep 21, 2023 · 6 comments
Closed

Opening search results in new tab setting #1774

asdeepasthepasific opened this issue Sep 21, 2023 · 6 comments
Assignees
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@asdeepasthepasific
Copy link

PROBLEM:

I always open my pages in new tabs. Google search has a setting to open the page you clicked in new tab but YouTube doesn't.

SOLUTION:

So I was wondering if you can add that feature to your extension.

ALTERNATIVES:

RELEVANCE / SCOPE:

Google has a setting for that and it is good when you look up stuff. Nowadays when you want to learn something, people go to YouTube before Google. That's why I think it is worth to add.

"SIDE EFFECTS":

CONTEXT:
//
Thank you!

SHORT Table (Summary)
Problem
Solution
Alternatives
Scope
Side effects
Context
@asdeepasthepasific asdeepasthepasific added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Sep 21, 2023
@asifurrahaman754
Copy link
Member

I would like to work on that, can anyone assign me?

@ImprovedTube
Copy link
Member

wonderful @asifurrahaman754 & @asdeepasthepasific
i'll use this feature too 🤫

@ImprovedTube
Copy link
Member

any chance you will have a look on the most urgent bugs too? @asifurrahaman754

@asifurrahaman754
Copy link
Member

asifurrahaman754 commented Sep 25, 2023

sure!

@asifurrahaman754
Copy link
Member

asifurrahaman754 commented Oct 7, 2023

@ImprovedTube please review my pr, sorry for this late update. I was exploring the codebase, also I was not familiar with extension development. But it was a great learning.

Also please add "hacktoberfest-accepted" label in that pr to add my contribution as a part of hacktoberfest.

ImprovedTube added a commit that referenced this issue Oct 10, 2023
feat: show searched video in new tab. issue #1774
@ImprovedTube
Copy link
Member

#1782

enjoy @asdeepasthepasific

ImprovedTube added a commit that referenced this issue Jan 12, 2024
feat: show searched video in new tab. issue #1774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants