Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live chat does not stretch to fit the window size when the window's width is small #1905

Closed
spikefdp opened this issue Dec 30, 2023 · 3 comments
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@spikefdp
Copy link

Bug Report:

BUG: When the browser's width is smaller than 1000px, Youtube moves the sidebar below the player and stretch its with to fit the window. However, when ImprovedTube is enabled (even with no settings changed at all), the live chat box does not stretch to fit the window and retains its min width. Tested on latest Firefox and Chrome + Firefox incognito mode (logged out).
HOW: Open a live stream or an archive then reduce your browser's width below 1000px. Compare it to when the extension is disabled.
⚬ ImprovedTube Version: 4.506

⚬ Browser: Tried both on Firefox 121.0 and Chrome 120.0.6099.130
⚬ Settings: Freshly installed
⚬ OS: Windows 11

⚬ Screenshot:
With ImprovedTube:
Screenshot 2023-12-30 at 16-33-35 Namibia Live stream in the Namib Desert

Without ImprovedTube:
Screenshot 2023-12-30 at 16-34-08 Namibia Live stream in the Namib Desert

@spikefdp spikefdp added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Dec 30, 2023
@BogdanskiJ
Copy link
Contributor

I correct the error.
I made PR: live chat strech issue 1905 fixed #1908

ImprovedTube added a commit that referenced this issue Dec 31, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Dec 31, 2023

hi! it is wonderful to see something happening on the day that we first added https://improvedtube.com/wishes to the popup

  • (is that why you thought of the project today? @BogdanskiJ @spikefdp)
    • should we make a mini repo for it, to encourage other projects to have run such a 'widget' too?

are there any more issues in small windows? @spikefdp @StickySli and can you test #1874 too? latest.zip

  • looking forward to make every fix for old screens (rare) and small windows (not that rare) @pankaj-2503
    ( some users also use a vertical tablet / phone but use youtube.com, not m.youtube.com)

@ImprovedTube ImprovedTube added Completition / Revision Rethink, complete, improve, tweak our feature or structure. and removed Bug Bug or required update after YouTube changes labels Jan 5, 2024
@ImprovedTube
Copy link
Member

...please test #1910 if you can

ImprovedTube added a commit that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants