-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
white empty menu screen. satus.js bug? language files denied? #2160
Comments
I dont even understand what that user means :) "it whiteout white screen"? whole screen? like actual page goes white? extension popup screen? the second one displays a message so its not really all white and no, for the hundreds time line breaks do not slow down loading files :--) parsing all the settings and language files sounds horrible, but it is 2024 Lines 899 to 902 in 7014a79
dynamic dom manipulations are really expensive, why is this created dynamically instead of being in index.html? moving it to index.html reduces load time from ~400 to ~200ms Still this is nothing compared to the time it takes to load all individual .js/CSS files, generate and render (browser repaint) satus-header/satus-main, and load expensive iframe from the web. Over 1 second for whole popup to show up. just one change 200ms faster #2163 Line 21 in 7014a79
Iv never ever seen that happen yet. |
ps I just did an experiment just for you ;) removed all EOL from messages.json and measured satus.storage.import() again, ZERO load time difference |
I meant a rare failure to show anything,
( since this got 4 votes. Only on that day, v4.820)
yes, thats why it said
and
😬😳
Yes, how much in average? amount of ms will vary by storage device & condition, - and if the extension was just updated, etc. ) They need not be split. Could combine them in one again(or else build with a build script. |
there sure are :o #1803 (comment) Lines 8 to 14 in 7014a79
moved to Lines 9 to 15 in 7014a79
changed #2163, this should solve any timing problems
best course of action for loading speed #1803 (comment) |
Update satus.js correct Menu load timing problems #2160
Similar has been around for years...
We load all settings every time the extension is clicked. Then chrome storage sometimes denies this for several seconds, resulting in:
...asking your browser what settings you made here before...
:youtube/menu/satus.js
Lines 891 to 912 in 01f8fa8
- Didnt trace what else might causes the white screen.
( Reported after this change 🤔 430d410 @raszpl ) likely a coincidence.
We also process the whole language file each time
youtube/menu/satus.js
Lines 1036 to 1105 in 01f8fa8
The issue seemed to be less frequent with smaller files.
This should most-likely be a coincidence though. ( Even Crowdin also just made them a bit longer again, but just four tabulator keys & two line breaks per message.
https://github.com/code-charity/youtube/pull/2039/files#diff-4127c9d4bf2969ed5053f8ecc759f3fb1239da11dac77cbd03ad11757e259c7e )
The text was updated successfully, but these errors were encountered: