Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Max speed greater than 2x #27

Closed
rzfzr opened this issue Feb 12, 2019 · 7 comments · Fixed by #161
Closed

[Feature request] Max speed greater than 2x #27

rzfzr opened this issue Feb 12, 2019 · 7 comments · Fixed by #161
Labels
Feature request Wish or idea

Comments

@rzfzr
Copy link

rzfzr commented Feb 12, 2019

Some extensions do it, might be one line of JS

@ghost ghost added the Feature request Wish or idea label Jul 26, 2019
@fazlerabbi37
Copy link

this one even allows you to assign shortcut key.

@rzfzr
Copy link
Author

rzfzr commented Aug 19, 2019

this one even allows you to assign shortcut key.

yep, but it has permission to read your history and is not open source from what I could see, so that's a no go

@Venryx
Copy link
Contributor

Venryx commented Nov 11, 2019

Some extensions do it, might be one line of JS

Indeed, it should be quite simple to implement. I know because it's literally only one line of code, even just running in the regular dev-tools console.

Just press F12 to open the dev-tools panel, switch to the Console tab, and run:

document.querySelector("video").playbackRate = 16; // or some other value

Since it's so straight-forward, it seems worth the few minutes to add.

(I tried modifying the template-parts/player.js file to allow a greater-than-2 max-value for the setting, and while that lets the user set it higher, apparently the method the plugin uses to apply it fails for values past 2. That's why the application method would have to be changed to the direct method described above.)

@Venryx
Copy link
Contributor

Venryx commented Nov 11, 2019

Turns out that it was indeed pretty straight-forward (though a bit more lines than expected since the extension has three places in code that can modify the playback speed!).

The pull-request (seen above) will now let users set the playback rate to anything between 0.1x and 16x. (the maximum range allowed for html5 videos)

this one even allows you to assign shortcut key.

By the way, assigning a shortcut key is already possible apparently through the "Popup->Shortcuts->[Increase/Decrease] Playback Speed" control. Tested and confirmed working with my PR above.

@rzfzr
Copy link
Author

rzfzr commented Nov 12, 2019

Great job,
hope the PR will be approved soon,
for now I have been using a combination of extensions that have served me well, however it would still be nice to have it all in one place.

This is for the shortcuts, works in any html5 video: https://chrome.google.com/webstore/detail/video-speed-controller/nffaoalbilbmmfgbnbgppjihopabppdk

This is for correcting the timeline and showing some stats (nice to haves in InprovedTube aswell): https://chrome.google.com/webstore/detail/youtube-time-tools/cobnfdhokdhiglbojmoapeccpbhonhgi

Take a look at these stats:
image

@wadawada
Copy link

@ghost ghost closed this as completed in #161 Nov 16, 2019
@Venryx
Copy link
Contributor

Venryx commented Dec 11, 2019

Can this issue please be re-opened?

My PR (#161) fixed this issue, however unfortunately the commit added to the end of the pull-request reverted some of my changes which were necessary to enable >2x playback speed for shortcut-key-based playback-speed changing.

Specifically, some of the changes in this linked commit and file (shortcuts.js -- it takes a while for the page to load and scroll), need to be re-added to get the >2x playback speed working for shortcut-keys: 7bed14e#diff-601eca5729d827909938694dc3c90d47

@victor-savinov Is there a reason you reverted the changes linked above? If so, how can it be changed to be acceptable? If the varying speed-adjustment increment is disliked, we can remove that part and just keep the fix enabling >2x playback-speed.

(I tried out the latest version of the extension, and confirmed that it maxes out at 2x, because the changes linked to above have the code regress to using player.setPlaybackRate, instead of videoNode.playbackRate, which is required to bypass the 2x speed.)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants