-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Max speed greater than 2x #27
Comments
this one even allows you to assign shortcut key. |
yep, but it has permission to read your history and is not open source from what I could see, so that's a no go |
Indeed, it should be quite simple to implement. I know because it's literally only one line of code, even just running in the regular dev-tools console. Just press F12 to open the dev-tools panel, switch to the Console tab, and run:
Since it's so straight-forward, it seems worth the few minutes to add. (I tried modifying the template-parts/player.js file to allow a greater-than-2 max-value for the setting, and while that lets the user set it higher, apparently the method the plugin uses to apply it fails for values past 2. That's why the application method would have to be changed to the direct method described above.) |
Turns out that it was indeed pretty straight-forward (though a bit more lines than expected since the extension has three places in code that can modify the playback speed!). The pull-request (seen above) will now let users set the playback rate to anything between 0.1x and 16x. (the maximum range allowed for html5 videos)
By the way, assigning a shortcut key is already possible apparently through the "Popup->Shortcuts->[Increase/Decrease] Playback Speed" control. Tested and confirmed working with my PR above. |
Great job, This is for the shortcuts, works in any html5 video: https://chrome.google.com/webstore/detail/video-speed-controller/nffaoalbilbmmfgbnbgppjihopabppdk This is for correcting the timeline and showing some stats (nice to haves in InprovedTube aswell): https://chrome.google.com/webstore/detail/youtube-time-tools/cobnfdhokdhiglbojmoapeccpbhonhgi |
I'm using this one. I like to drag |
Can this issue please be re-opened? My PR (#161) fixed this issue, however unfortunately the commit added to the end of the pull-request reverted some of my changes which were necessary to enable >2x playback speed for shortcut-key-based playback-speed changing. Specifically, some of the changes in this linked commit and file (shortcuts.js -- it takes a while for the page to load and scroll), need to be re-added to get the >2x playback speed working for shortcut-keys: 7bed14e#diff-601eca5729d827909938694dc3c90d47 @victor-savinov Is there a reason you reverted the changes linked above? If so, how can it be changed to be acceptable? If the varying speed-adjustment increment is disliked, we can remove that part and just keep the fix enabling >2x playback-speed. (I tried out the latest version of the extension, and confirmed that it maxes out at 2x, because the changes linked to above have the code regress to using |
Some extensions do it, might be one line of JS
The text was updated successfully, but these errors were encountered: