Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add option to reduce quality when window loses focus #300

Closed
Tracked by #2240
thejavascriptman opened this issue May 7, 2020 · 2 comments
Closed
Tracked by #2240
Assignees
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) 🧩Plan ready Solution or full specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Milestone

Comments

@thejavascriptman
Copy link

Feature Description:
Please consider adding an additional option to reduce playback quality when window loses focus.

Reason:
On many configurations video playback uses a lot of CPU due to hardware decoding not being used, this usually happens on Linux and even on Windows when the user is forced to disable hardware decoding due to buggy video drivers.

How would it work?
Basically when a video is being played while the respective browser window is focused, quality setting should work as it is working right now, however if the browser loses focus (i.e. if it's being minimized or another window gains focus), quality could go down to 360p, so processor usage would be lower (if the option is enabled)

Possible issues:
I understand that some buffering could happen when switching focus, but IMHO that's a worthy tradeoff for this kind of feature

Sample mockup:
sample

@ghost ghost added the enhancement (medium) label May 7, 2020
@ghost ghost removed medium labels Dec 11, 2020
@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@ImprovedTube ImprovedTube added good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Oct 19, 2023
@Alpaczyk
Copy link
Contributor

Hi, I would like to work on it @thejavascriptman @ImprovedTube

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 22, 2024

thank you @Alpaczyk, great choice!

On many configurations video playback uses a lot of CPU

Dont bandwidth & cpu go down at all for background playing? @thejavascriptman

Possible issues:
I understand that some buffering could happen when switching focus, but IMHO that's a worthy tradeoff for this kind of feature

In theory it could delay switching quality until buffer is empty. (are buffer features history yet? #581)
Instead we could work with a timer like 10 seconds without going back to the tab, or any value the user sets.
and minimum remaining video duration like 20 seconds. (and low quality from the start if another video starts afterwards.)


Similar:

#2239

@ImprovedTube ImprovedTube added the 🧩Plan ready Solution or full specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) label Mar 22, 2024
@ImprovedTube ImprovedTube added Completition / Revision Rethink, complete, improve, tweak our feature or structure. and removed Feature request Wish or idea labels Apr 4, 2024
ImprovedTube added a commit that referenced this issue Apr 27, 2024
Feature #300: Reduce quality when window loses focus (from pull request #2162)
ImprovedTube added a commit that referenced this issue Apr 27, 2024
ImprovedTube added a commit that referenced this issue Apr 27, 2024
ImprovedTube added a commit that referenced this issue Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) 🧩Plan ready Solution or full specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: Done
Development

No branches or pull requests

3 participants