Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #1395 #1396

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Fixed Issue #1395 #1396

merged 4 commits into from
Sep 27, 2022

Conversation

hboyd2003
Copy link
Contributor

Fixed the channel video count

@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 26, 2022

Dear @hboyd2003, thank you again! ⭐ and so sorry to delay the complete reaction! (i didnt expect our hero contributor & maintainer to pause #1405) (and i didnt write this feature.)

why are you making a second API request?
EDIT: We just wrote this to include you in the full context #1452

@hboyd2003
Copy link
Contributor Author

@ImprovedTube The original code takes the URL to the channel and pulls the channel ID from that then uses the ID to make an api request.

The issue comes when a channel has a custom channel URL thus the channel ID is not in the URL. So a api request that uses the video ID to then get the channel ID works best.

Its possible (and probable) that the channel ID does exist somewhere on the page but I could not find it.

I’ll add a check to test if the url is a custom url or not so we can cut down on API requests.

@hboyd2003
Copy link
Contributor Author

@ImprovedTube It should now only make two API requests when a user has a custom channel ID

@ImprovedTube ImprovedTube merged commit 5a1cc7f into code-charity:master Sep 27, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 27, 2022

Thanks!! This will cut confusions a lot soon.
There's more often & you might be able to guess netter than me who are the xx,xxx users of the feature or answer ( #1452 "1.")

ImprovedTube added a commit that referenced this pull request Oct 16, 2022
ImprovedTube added a commit that referenced this pull request Oct 18, 2022
ImprovedTube added a commit that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants